Conversation
# Conflicts: # build.gradle
✨ feat : 맞춤 추천용 메뉴 목록 조회 API
👷 CI : CI/CD 파이프라인 구축
💚 CI: CI/CD 파이프라인 설정 수정
💚 CI. cd 실행 시, 환경변수가 적용되지 않는 문제 해결
✨ feat : 특정 메뉴를 파는 가게 조회 API 구현
frombunny
requested changes
Aug 13, 2025
Comment on lines
11
to
12
| @Min(value=1, message="quantity는 1 이상이어야 합니다.") | ||
| private int quantity; |
| menu.getCostPrice(), | ||
| menu.getSalePrice(), | ||
| store.getName(), | ||
| quantity |
Member
There was a problem hiding this comment.
수량도 받지 말고 menu에서 받아오면 좋을 것 같구, 할인율도 계산해서 반환하면 좋을 것 같아요!
store는 위에서 Store store = menu.getStore(); 이렇게 할 필요 없이 menu.getStore().getName() 이렇게 받읍시다!
Comment on lines
82
to
93
| public List<MenuDetailsRes> details(MenuDetailsListReq menus) { | ||
| Map<Long, Integer> menuMap = menus.getMenus().stream() | ||
| .collect(Collectors.toMap(MenuDetailsReq::getMenuId, MenuDetailsReq::getQuantity)); | ||
|
|
||
| List<Menu> menuList = menuRepository.findAllById(menuMap.keySet()); | ||
|
|
||
| if (menuList.isEmpty()) {throw new MenuNotFoundException();} | ||
|
|
||
| return menuList.stream() | ||
| .map(menu -> MenuDetailsRes.from(menu, menuMap.get(menu.getId()))) | ||
| .toList(); | ||
| } |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 관련 이슈
✅ 작업 분류
✨ 작업 내용
👥 전달사항
✅ 체크리스트
📸 스크린샷